+1 for 100 On Thu, Mar 22, 2012 at 7:08 AM, Anoop Sam John <anoo...@huawei.com> wrote:
> +1 for 100 chars > ________________________________________ > From: Li Pi [l...@idle.li] > Sent: Thursday, March 22, 2012 10:55 AM > To: dev@hbase.apache.org; V v lakshmana kumar chekka > Subject: Re: HBASE Code format > > +1. > > On Wed, Mar 21, 2012 at 10:17 PM, Laxman <lakshman...@huawei.com> wrote: > > > Hi Devs, > > > > How about raising the "max line width" from 80 (to 100 or 120)? > > IMO, 80 characters length is too low & it makes the code bit ugly. > > > > Example: > > long timstamp = conf.getLong(TIMESTAMP_CONF_KEY, > > System.currentTimeMillis()); > > > > Above code snippet after formatting, it turned to > > > > long timstamp = conf > > .getLong(TIMESTAMP_CONF_KEY, System.currentTimeMillis()); > > > > Please respond with your opinion considering the following points. > > > > - Sun Java coding standards drafted in 1999 > > - Terminals(Monitors) we are using now are very wider and 80 characters > is > > not a valid limit anymore. > > - As per Ted, Google raised this limit > > [https://issues.apache.org/jira/browse/HBASE-5564] > > > > Note: We don't need to reformat entire codebase. My proposal is to apply > > these standards to new code getting commited. > > > > -- > > Regards, > > Laxman > > > > > > >
