Hi Jesse, Yes, I tried, reducing the sleep does not change much the test time :-).
I took these two as example, as 5 minutes seemed to be a lot to me (with the current config, it slows down the global build by more than 1 minute alone), and I think it's easier to tackle this at the very beginning. After a year or two, when many contributors added tests, fixed bugs and so on, it's more difficult to change things: you always fear that you're going to decrease the test coverage. And it may requires to change the main code to ease hooking/mocking & so on. It's obviously easier to do during the dev than post dev... Cheers, Nicolas On Fri, Aug 24, 2012 at 9:07 PM, Jesse Yates <[email protected]> wrote: > On Fri, Aug 24, 2012 at 6:54 AM, N Keywal <[email protected]> wrote: > >> >> I've seen as well these ones: >> Running >> org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient >> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 284.153 sec >> >> This one was me. It does a bunch of waiting for compactions to preceed via > the high level API and also coordination via ZK (so full cluster setup/down > is included in the test time). > > There is a forced sleep (currently 1000ms) but that is a far smaller than > the overall runtime. It just that compactions seem to take a while. I can > take a look early next week though if we really want to crank down the time > - it is categorized a Large though... > > -Jesse
