I'll leave it be in the code for now but will open a jira issue. The only place i see Collections.sort being called on KeyValues is in RedundantKeyValueGenerator test code.
On Mon, Oct 1, 2012 at 10:00 AM, Stack <[email protected]> wrote: > On Sun, Sep 30, 2012 at 5:47 PM, Matt Corgan <[email protected]> wrote: > > Hi everyone, > > > > Working on PrefixTree testing I noticed that KeyValue.KVComparator > includes > > the memstoreTS when comparing, however the KeyValue.equals() method > ignores > > the memstoreTS. > > Sounds like bug/oversight Matt. I'd think msts should be factored into > equals. > > > On the other hand, KVComparator isn't technically the default comparator > so > > I wouldn't say it's a bug. > > > > Java 7 sidenote - We ran into this problem internally at HotPads when > > moving to Java 7. The > > Comparator< > http://docs.oracle.com/javase/7/docs/api/java/util/Comparator.html> > > interface > > has always specified that comparator return 0 when equals would return > true > > and vice versa. Obeying that rule has been sort of optional in the past, > > but Java 7 introduces a new default collection sorting algorithm called > Tim > > Sort <http://bugs.sun.com/view_bug.do?bug_id=6804124> which relies on > that > > behavior. We've been using a VM argument to roll back to the old sorting > > algorithm. > > > > Thanks for pointer. Need to fix now trunk builds on jenkins w/ jdk7. > > St.Ack >
