On Sat, Nov 24, 2012 at 10:36 PM, lars hofhansl <[email protected]> wrote: > missed that README. Anyway, wasn't hard to figure out, just wondered why > there wasn't a convenient maven target. >
My guess is that it was thought the content of the README enough. You think we should add the mvn target? If so, make issue and I'll have a go at it. > While we're at the topic. I found that Put/Delecte and Increment still > implement the Writable interface and still provide write and readFields > methods. > > > A feeble attempt to just remove them shows that they are still used here: > - IdentityTableReduce.java > - MultiPut.java > - HRegionServer.checkAndMutate > > > Are these still needed for M/R or in HBaseObjectWritable? > > If we end up having to keep these writable implementations around it pretty > much defeats the wire compatibility goal. > Please make a a blocker issue on 0.96. Good on you Lars, St.Ack <[email protected]> > To: [email protected]; lars hofhansl <[email protected]> > Sent: Saturday, November 24, 2012 10:05 PM > Subject: Re: No protoc maven target? > > This is true you have to run it, but > hbase-server/src/main/protobuf/README.txt which cut-and-paste instructions. > > Would probably be better to add a build-protos shell script to dev-support/. > > Jon. > > On Sat, Nov 24, 2012 at 9:58 PM, lars hofhansl <[email protected]> wrote: > >> I might just be a bit dense tonight, but do I really have to call protoc >> see myself (lookup the right options, figure out the right output path) >> when I change a .proto file? >> That's what I ended up doing, because there appears to be no maven target >> to regenerated the protobuf related files. >> >> -- Lars >> > > > > -- > // Jonathan Hsieh (shay) > // Software Engineer, Cloudera > // [email protected]
