+1. file, fix, and since trivial, I'd say feel free to commit. Jon.
On Fri, Dec 21, 2012 at 3:22 PM, Ted Yu <[email protected]> wrote: > Hi, > There are two constants with the same value: > HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT > > HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests. > HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil > > Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use > HConstants.ZK_SESSION_TIMEOUT ? > > Cheers -- // Jonathan Hsieh (shay) // Software Engineer, Cloudera // [email protected]
