Jerry He created HBASE-8225:
-------------------------------

             Summary: [replication] minor code bug when registering 
ReplicationLogCleaner
                 Key: HBASE-8225
                 URL: https://issues.apache.org/jira/browse/HBASE-8225
             Project: HBase
          Issue Type: Bug
          Components: Replication
    Affects Versions: 0.94.6
            Reporter: Jerry He
            Assignee: Jerry He
            Priority: Minor
             Fix For: 0.95.0, 0.96.0, 0.94.7


We try to register ReplicationLogCleaner by default. This is done by calling 
Replication.decorateMasterConfiguration()in the master. 

In the current Replication.decorateMasterConfiguration(): 
...
    String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS);
    if (!plugins.contains(ReplicationLogCleaner.class.toString())) {
      conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS,
          plugins + "," + ReplicationLogCleaner.class.getCanonicalName());
    }
...

ReplicationLogCleaner.class.toString() will return prefix 'class' to the full 
class name, which will make the if checking mostly useless.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to