Thanks for having a look. If you don't mind terribly, I responded to your comments on JIRA [0].
Thanks, Nick [0]: https://issues.apache.org/jira/browse/HBASE-8693#comment-13711250 On Wed, Jul 17, 2013 at 1:42 AM, Matteo Bertozzi <[email protected]>wrote: > I was looking at the HBASE-8693 patch, and looks good to me for the > primitive types. > but I can't see how do you plan to evolve stuff like the struct. > By "evolve" I mean add/remove fields, or just query it with a subset of > fields. > the fields don't have an id, and on read you must specify all of them in > the same order as you've used for write. > (but maybe is just an immutable/fixed list of fields, and I'm ok with just > adding that info to the comment on top of the class) > > > Matteo > > > > On Wed, Jul 17, 2013 at 12:39 AM, Nick Dimiduk <[email protected]> wrote: > > > New patch posted. What do you think about the new isSkippable() and the > > associated limitation in Struct? > > > > I also posted some "dogfeed" per Enis's suggestion. > > > > -n > > > > On Fri, Jul 12, 2013 at 1:38 PM, Stack <[email protected]> wrote: > > > > > On Fri, Jul 12, 2013 at 1:10 PM, Enis Söztutar <[email protected]> > wrote: > > > > > > > Did some chatting with Nick today. > > > > > > > > I think it is really important to get this right, and for that we > would > > > > definitely need more eyes towards it. The current patch set is in a > > good > > > > state to bolster the discussion. > > > > > > > > > > > > > > I'll do another pass (Kicking others to give it a looksee too). > > > St.Ack > > > > > >
