Ted Yu created HBASE-9927:
-----------------------------

             Summary: ReplicationLogCleaner#stop() calls 
HConnectionManager#deleteConnection() unnecessarily
                 Key: HBASE-9927
                 URL: https://issues.apache.org/jira/browse/HBASE-9927
             Project: HBase
          Issue Type: Task
            Reporter: Ted Yu
            Priority: Minor


When inspecting log, I found the following:
{code}
2013-11-08 18:23:48,472 ERROR [M:0;kiyo:42380.oldLogCleaner] 
client.HConnectionManager(468): Connection not found in the list, can't delete 
it (connection key=HConnectionKey{properties={hbase.rpc.timeout=60000, 
hbase.zookeeper.property.clientPort=59832, hbase.client.pause=100, 
zookeeper.znode.parent=/hbase, hbase.client.retries.number=350, 
hbase.zookeeper.quorum=localhost}, username='zy'}). May be the key was modified?
java.lang.Exception
        at 
org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:468)
        at 
org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:404)
        at 
org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.stop(ReplicationLogCleaner.java:141)
        at 
org.apache.hadoop.hbase.master.cleaner.CleanerChore.cleanup(CleanerChore.java:276)
{code}
The call to HConnectionManager#deleteConnection() is not needed.
Here is related code which has a comment for this effect:
{code}
    // Not sure why we're deleting a connection that we never acquired or used
    HConnectionManager.deleteConnection(this.getConf());
{code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to