+ public void setLength(long length) {
This method in TableSplit can be package private.
+ final Log LOG = LogFactory.getLog(MultiTableInputFormatBase.class);
Name of class is wrong.
+ makeFamilyFilter(families);
The return value is ignored.
Can you make a patch for trunk and attach to JIRA ?
Thanks
On Fri, Jan 31, 2014 at 6:55 AM, Lukas Nalezenec <
[email protected]> wrote:
> Hi,
> I have written first draft: https://github.com/
> lukasnalezenec/hbase/commit/bf560b3c19b15cefb114132ac86664ffc44dad32
> Can you please review it and let mi know it is feasible solution ?
> Lukas
>
>
> On 30.1.2014 18:14, Nick Dimiduk wrote:
>
>> Sounds good, I'll watch for your patch!
>>
>> On Thursday, January 30, 2014, Lukas Nalezenec <
>>
>> [email protected]> wrote:
>>
>> I talked with guy who worked on this and he said our production issue was
>>> probably not directly caused by getLength() returning 0.
>>> Anyway, we are interested in fixing that, estimating length from files is
>>> good idea.
>>>
>>> Lukas
>>>
>>> InputSplit.getLength() and RecordReader.getProgress() is important for
>>> the
>>>
>>>> MR framework to be able to show progress etc. It would be good to return
>>>> raw data sizes in getLength() computed from region's total size of store
>>>> files, and progress being calculated from scanner's amount of raw data
>>>> seen.
>>>>
>>>> Enis
>>>
>>>
>>>
>>>
>
