bq. filterKeyValue is part of public/Stable Filter interface As I mentioned in my first email: FilterBase.java has been marked @InterfaceAudience.Private since 0.96
Client Filters are free to override filterKeyValue(Cell ignored) in their implementation. Cheers On Mon, Feb 24, 2014 at 5:52 PM, Jeffrey Zhong <[email protected]>wrote: > > filterKeyValue is part of public/Stable Filter interface. > > For example, Phoenix use filterKeyValue in many places. I guess there are > other hbase applications implements filters with this function.Therefore, > it will break compatibilities for some applications so it's better we can > firstly desecrated this function and remove it in later major release. > > > Thanks, > -Jeffrey > > On 2/24/14 5:33 PM, "Ted Yu" <[email protected]> wrote: > > >Thanks for the confirmation, Lars. > > > >Will wait for a few days before opening JIRA. > > > > > >On Mon, Feb 24, 2014 at 4:19 PM, lars hofhansl <[email protected]> wrote: > > > >> Let's remove it and add adequate documentation. It has been the source > >>of > >> too many problems. > >> > >> If filterRowKey returns true filterKeyValue needs to be consistent with > >>it. > >> filterKeyValue can assume that filterRowKey has already been called for > >> the row. > >> > >> -- Lars > >> > >> > >> > >> ________________________________ > >> From: Ted Yu <[email protected]> > >> To: "[email protected]" <[email protected]> > >> Sent: Monday, February 24, 2014 9:44 AM > >> Subject: Discussion: dropping filterKeyValue(Cell ignored) from > >>FilterBase > >> > >> > >> Hi, > >> FilterBase.java has been marked @InterfaceAudience.Private since 0.96 > >> I want to get your opinion on making potential change to FilterBase - > >> dropping filterKeyValue(Cell ignored). > >> > >> You can find background in HBASE-10485: PrefixFilter#filterKeyValue() > >> should perform filtering on row key > >> > >> My thinking is that dropping filterKeyValue(Cell ignored) would let > >> developers make conscientious decision on when ReturnCode.INCLUDE > >>should be > >> returned. > >> This is for 0.99 only. > >> > >> Your opinion is appreciated. > >> > >> Thanks > > > > -- > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity to > which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. >
