I agree with what Enis said. Cheers
On Jul 19, 2014, at 11:03 PM, Enis Söztutar <[email protected]> wrote: > I don't think we should have much formatting restrictions around patches. > git format patch is nice to use, and if the author provides it the > committers can use, but I don't think we should force that for every patch. > > just my 2 cents. > Enis > > > On Sat, Jul 19, 2014 at 1:48 AM, Aditya <[email protected]> wrote: > >> Now that the primary source repository for HBase is Git, shouldn't we move >> to "git-am" format patches? >> >> >> On Thu, Jul 17, 2014 at 5:39 PM, Enis Söztutar <[email protected]> wrote: >> >>> Hi, >>> >>> It seems for some time, the hadoopqa script cannot apply the patches >>> generated for -p0. I've emailed Giri about it, who recently moved the >>> jenkins builds nodes in builds.apache.org. We believe that the issue >> maybe >>> about the default shell not being bash, but waiting for him to come back >>> from vacation. >>> >>> In the meantime I've disabled the smart handling of -p0 patches. The >> patch >>> application should work now except for patches which just add new files. >> If >>> you have such a patch, please make sure that it is generated for -p0. >>> >>> Enis >>
