Please don't change the ordering of fields, that's required for backwards compatibility.
On Wed, Oct 15, 2014 at 10:03 AM, Ted Yu <[email protected]> wrote: > Adding Tim and Lars who are familiar with thrift(2) modules. > > bq. Should the changes in these classes be part of my patch? > > Yes. > > Cheers > > On Wed, Oct 15, 2014 at 9:20 AM, Niels Basjes <[email protected]> wrote: > > > Hi, > > > > I'm trying to create a good patch for HBASE-12269. > > I have a few basic questions about the patch I should submit. > > > > 1) In the thrift interface the elements are numbered. > > - Is it better to put "the new thing I'm building" in a logical place > > (i.e. somewhere in the middle causing all later fields to get a different > > number) > > - or to put it at the end? > > 2) Apparently the generated thrift code has been committed to version > > control. > > - Should the changes in these classes be part of my patch? > > - If so, which version of thrift should be used (0.9.0/0.9.1/... ?) > and > > what is the 100% accurate correct command to generate them? > > - For my own purpose I created a small shell script so I can repeat > the > > command I have now (see below). Shall I include this as a separate script > > in my patch? > > > > > > The script I created here is hbase-thrift/generate-thrift-classes.sh > > #!/bin/bash > > thrift -v --gen java -out src/main/java/ > > src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift > > thrift -v --gen java -out src/main/java/ > > src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift > > > > > > -- > > Best regards / Met vriendelijke groeten, > > > > Niels Basjes > > >
