The new version should've solved this problem. Thanks for reporting. David
On Wed, Oct 15, 2014 at 11:09 AM, Ted Yu <[email protected]> wrote: > David: > Thanks for the new feature. > > I found a little rendering bug. If you look at the following using your > plugin: > > https://issues.apache.org/jira/secure/attachment/12675067/HBASE-12267_v2.patch > > You would see that the 3rd line below (MultiTableOutputFormat.java): > public void close(TaskAttemptContext context) throws IOException { - for > (HTable table : tables.values()) { + for (Pair<Connection, Table> pair : > tables.values()) { > > becomes: > for (Pair<Connection, Table> pair : tables.values()) { > > On Tue, Oct 14, 2014 at 10:05 PM, David DENG <[email protected]> > wrote: > > > Version 1.5 has been submitted. Click on the icon to switch between > > original and formatted. > > > > On Tue, Oct 14, 2014 at 6:43 AM, David DENG <[email protected]> > wrote: > > > > > I'll make clicks on the icon on toolbar switching between original and > > > formatted. Couldn't be later than this weekend. > > > > > > David > > > > > > On Mon, Oct 13, 2014 at 10:19 PM, tobe <[email protected]> wrote: > > > > > >> I could like to copy the address in Firefox to view the original file > or > > >> just disable the plugin. > > >> > > >> On Tue, Oct 14, 2014 at 12:08 PM, Ted Yu <[email protected]> wrote: > > >> > > >> > Sometimes the reviewer may want to reference some particular diff in > > >> review > > >> > comment. > > >> > > > >> > Is there a way to switch back to viewing the text of the patch ? > > >> > > > >> > I fully understand that you have other priorities. > > >> > > > >> > Cheers > > >> > > > >> > On Sat, Oct 11, 2014 at 9:37 PM, David DENG <[email protected]> > > >> wrote: > > >> > > > >> > > Published a new version of the exteions: > > >> > > > > >> > > 1. An icon is shown right to the address bar. When viewing patch > in > > an > > >> > > arbitrary url, click on the icon, it'll be rendered. This support > > >> cause > > >> > the > > >> > > extension needs a re-enabling when upgraded. (Sorry for the > > >> re-enalbing) > > >> > > > > >> > > 2. Add an option page to set url patterns which are auto rendered. > > >> > Default > > >> > > values are Apache jira patches (added [.]txt pattern) > > >> > > > > >> > > David > > >> > > > > >> > > On Fri, Oct 10, 2014 at 6:22 PM, Ted Yu <[email protected]> > > wrote: > > >> > > > > >> > > > Yes. > > >> > > > > > >> > > > See https://issues.apache.org/jira/browse/HBASE-12164 > > >> > > > > > >> > > > On Fri, Oct 10, 2014 at 5:58 PM, David DENG < > > [email protected]> > > >> > > wrote: > > >> > > > > > >> > > > > @Ted, people also submit patch with .txt extension? > > >> > > > > > > >> > > > > David > > >> > > > > > > >> > > > > On Fri, Oct 10, 2014 at 5:35 PM, Ted Yu <[email protected]> > > >> wrote: > > >> > > > > > > >> > > > > > Interesting. > > >> > > > > > > > >> > > > > > Can you add the following to the recognized patterns ? > > >> > > > > > > > >> > > > > > https://issues.apache.org/jira/secure/attachment/*/*. > > >> > > > > > <https://issues.apache.org/jira/secure/attachment/*/*.patch > > >txt > > >> > > > > > > > >> > > > > > On Fri, Oct 10, 2014 at 4:57 PM, David DENG < > > >> [email protected] > > >> > > > > >> > > > > wrote: > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg > > >> > > > > > > > > >> > > > > > > Go to one of the JIRA patch, the raw text will be rendered > > as > > >> a > > >> > > > > > Phabricator > > >> > > > > > > like page (Like http://review.facebook.net/ ). > > >> > > > > > > Recognized URL pattern: > > >> > > > > > > > https://issues.apache.org/jira/secure/attachment/*/*.patch > > >> > > > > > > > > >> > > > > > > Source code and bug report: > > >> > > https://github.com/daviddengcn/patch-ext > > >> > > > > > > > > >> > > > > > > Have a try and enjoy! > > >> > > > > > > > > >> > > > > > > David > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > > > > > > >
