----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://review.cloudera.org/r/4884/#review8003 -----------------------------------------------------------
Ship it! I don't see the delta from upstream except for maybe spacing nits. take care of those upstream. otherwise lgtm. hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java <https://review.cloudera.org/r/4884/#comment12936> nit (if upstream, fix there too) hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java <https://review.cloudera.org/r/4884/#comment12937> nit (fix upstream if there) - Jonathan Hsieh On Feb. 4, 2015, 9:55 p.m., Srikanth Srungarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://review.cloudera.org/r/4884/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 9:55 p.m.) > > > Review request for hbase. > > > Repository: hbase > > > Description > ------- > > Summarizing discussion on HBASE-12533: > Looks like the prepareBulkLoad is fired up to hit all data regions so it will > create same number of staging folders as the number of regions of the > bulkloaded table while we only use the first one. That's why you can see many > staging folders are left. > > > Diffs > ----- > > > hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java > 48986b1eb6a45ca57f40cfe0e99ed302a024d2d1 > > hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java > fcb9270e3d33f48ae6cfed3ea4cbe0874f0a37ef > > hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java > 27c809a3b71bfcb465703cf66f896098935e2da0 > > Diff: https://review.cloudera.org/r/4884/diff/ > > > Testing > ------- > > Local testing done. > > > Thanks, > > Srikanth Srungarapu > >
