Hi, folks 1. In EnabledTableSnapshotHandler in
protected void snapshotRegions(List<Pair<HRegionInfo, ServerName>> regions) why do we make snapshot for offline and split regions after all online regions are done? 2. Do we have a possible race condition in SnapshotManifest: a. When we get a list of a store files in public void addRegion(final HRegion region) b. then we iterate over this list and do some work c. then we close snapshot for region and save manifest to a file between a. and c. some files from list in a. can become invalid (deleted by HFileCleaner). I checked the code, no exception is raised if file is no longer exists during this phase. thanks, -Vlad
