[
https://issues.apache.org/jira/browse/HBASE-7026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Lawlor resolved HBASE-7026.
------------------------------------
Resolution: Fixed
Marking this old one as fixed. I do not see these metrics being recorded inside
StoreScanner anymore and thus potential performance regressions seem to have
been addressed.
> Make metrics collection in StoreScanner.java more efficient
> -----------------------------------------------------------
>
> Key: HBASE-7026
> URL: https://issues.apache.org/jira/browse/HBASE-7026
> Project: HBase
> Issue Type: Sub-task
> Reporter: Karthik Ranganathan
> Assignee: Karthik Ranganathan
>
> Per the benchmarks I ran, the following block of code seems to be inefficient:
> StoreScanner.java:
> public synchronized boolean next(List<KeyValue> outResult, int limit,
> String metric) throws IOException {
> // ...
> // update the counter
> if (addedResultsSize > 0 && metric != null) {
> HRegion.incrNumericMetric(this.metricNamePrefix + metric,
> addedResultsSize);
> }
> // ...
> Removing this block increased throughput by 10%. We should move this to the
> outer layer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
