Hi Appy!
I'm copying in dev@yetus, since those folks are better positioned to answer
these questions.
The output for checkstyle is only present on that build because the patch
that it is testing only changed the hbase-server module. By default Yetus
only does correctness checks on modules that have been changed. Currently
the HBase personality maintains this behavior.
It might help explain the five files to arrange them in terms of the phases
Yetus Precommit uses when evaluating a patch[1] (I've skipped phases
unrelated to checkstyle):
- post-compile for branch (e.g. master, branch-1, branch-1.2, etc)
after checking out and installing everything, changed modules have
checkstyle run against the _current_ state of the repo
-- the checkstyle results go into branch-checkstyle-${module_name}.txt
-- the console output of running the checkstyle command (since hbase uses
maven) goes into maven-branch-checkstyle-${module_name}.txt
- post-compile for patch (i.e. after applying the changes to be tested)
-- the checkstyle results go into patch-checkstyle-${module_name}.txt
-- the console output of running the checkstyle command (since hbase uses
maven) goes into maven-branch-checkstyle-${module_name}.txt
-- the difference between the branch and patch versions of the checkstyle
output is calculated[2] and stored in diff-checkstyle-${module}.txt
Sounds like we (Yetus) should build some overview docs on plugins. Thanks
for the question!
[1]: http://yetus.apache.org/documentation/0.1.0/precommit-architecture/
[2]:
https://github.com/apache/yetus/blob/master/precommit/test-patch.d/checkstyle.sh#L65
On Sun, Jan 24, 2016 at 5:44 PM, Apekshit Sharma <[email protected]> wrote:
> So looking at artifacts of a build (
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/261/artifact/patchprocess/
> ),
> I see checkstyle for only 'hbase-server', why so? Is it that we haven't
> turned it on for other modules yet?
>
> Also I see following five different files, what is each one for?
>
> - branch-checkstyle-hbase-server.txt
> - diff-checkstyle-hbase-server.txt
> - maven-branch-checkstyle-hbase-server.txt
> - maven-patch-checkstyle-hbase-server.txt
> - patch-checkstyle-hbase-server.txt
>
>
> - Appy
>
--
Sean
