Allan Yang created HBASE-16816:

             Summary: HMaster.move() should throw exception if region to move 
is not online
                 Key: HBASE-16816
             Project: HBase
          Issue Type: Bug
          Components: Admin
    Affects Versions: 1.1.2
            Reporter: Allan Yang
            Assignee: Allan Yang
            Priority: Minor

The move region function in HMaster only checked the region to move if it is 
not exist. 
if (regionState == null) {
      throw new UnknownRegionException(Bytes.toStringBinary(encodedRegionName));


It will not return anything if the region is split or in transition which is 
not movable. So the caller has no way to know if the move region operation is 
It is a problem for "region_move.rb". It only gives up moving a region if a 
exception is thrown.Otherwise, it will wait until a timeout and retry. Without 
a exception, it have no idea the region is not movable.
      admin.move(Bytes.toBytes(r.getEncodedName()), Bytes.toBytes(newServer))
    rescue java.lang.reflect.UndeclaredThrowableException,
        org.apache.hadoop.hbase.UnknownRegionException => e
      $"Exception moving "  + r.getEncodedName() +
        "; split/moved? Continuing: " + e)
 # Wait till its up on new server before moving on
    maxWaitInSeconds = admin.getConfiguration.getInt("hbase.move.wait.max", 60)
    maxWait = + maxWaitInSeconds
    while < maxWait
      same = isSameServer(admin, r, original)
      break unless same
      sleep 0.1

This message was sent by Atlassian JIRA

Reply via email to