Ted Yu created HBASE-16929:
------------------------------

             Summary: Move default method of shipped to Shipper interface
                 Key: HBASE-16929
                 URL: https://issues.apache.org/jira/browse/HBASE-16929
             Project: HBase
          Issue Type: Bug
            Reporter: Ted Yu
            Assignee: Ted Yu


HBASE-16626 added default method of shipped() to RegionScanner.

However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:
{code}
[ERROR] 
/a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8]
 org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and does 
not override  abstract method shipped() in 
org.apache.hadoop.hbase.regionserver.Shipper
[ERROR] 
/a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36]
 <anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is not  
       abstract and does not override abstract method shipped() in 
org.apache.hadoop.hbase.regionserver.Shipper
{code}
Here is the snippet for DelegateRegionScanner:
{code}
public class DelegateRegionScanner implements RegionScanner {
{code}
It seems adding default method in RegionScanner is not enough for downstream 
projects.

After moving the default method to Shipper interface, the above two compilation 
errors are gone in Phoenix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to