I applied addendum and ran a few unit tests which passed. FYI
On Thu, Oct 27, 2016 at 8:44 AM, Ted Yu <yuzhih...@gmail.com> wrote: > It turns out that HBASE-16932 moved the definition of MAX_BYTE_ARRAY : > > git show cd3dd6e018513357d2cf0b5bba073f5a6551f7a4 > ./hbase-client/src/main/java/org/apache/hadoop/hbase/ > client/ClientScanner.java > > - static byte[] MAX_BYTE_ARRAY = Bytes.createMaxByteArray(9); > > On Thu, Oct 27, 2016 at 8:10 AM, Andrew Purtell <andrew.purt...@gmail.com> > wrote: > >> I checked the last QA report on this issue and, while the findbugs and >> unit test results were red, there was nothing that would indicate the site >> build would fail. >> >> Am I missing something? >> >> Is the only way we will know if a change will break the site build is to >> run a site build before every check in? >> >> If so, that won't work out well. Can we add a site check to precommit? >> >> > On Oct 27, 2016, at 10:54 AM, Dima Spivak <dimaspi...@apache.org> >> wrote: >> > >> > HBASE-16886 breaks compilation. Ted, please revert. >> > >> > On Thursday, October 27, 2016, Apache Jenkins Server < >> > jenk...@builds.apache.org> wrote: >> > >> >> Build status: Failure >> >> >> >> If successful, the website and docs have been generated. To update the >> >> live site, follow the instructions below. If failed, skip to the >> bottom of >> >> this email. >> >> >> >> Use the following commands to download the patch and apply it to a >> clean >> >> branch based on origin/asf-site. If you prefer to keep the hbase-site >> repo >> >> around permanently, you can skip the clone step. >> >> >> >> git clone https://git-wip-us.apache.org/repos/asf/hbase-site.git >> >> >> >> cd hbase-site >> >> wget -O- https://builds.apache.org/job/hbase_generate_website/390/ >> >> artifact/website.patch.zip | funzip > ${GIT_SHA}.patch >> >> git fetch >> >> git checkout -b asf-site-${GIT_SHA} origin/asf-site >> >> git am --whitespace=fix $GIT_SHA.patch >> >> >> >> At this point, you can preview the changes by opening index.html or >> any of >> >> the other HTML pages in your local asf-site-${GIT_SHA} branch. >> >> >> >> There are lots of spurious changes, such as timestamps and CSS styles >> in >> >> tables, so a generic git diff is not very useful. To see a list of >> files >> >> that have been added, deleted, renamed, changed type, or are otherwise >> >> interesting, use the following command: >> >> >> >> git diff --name-status --diff-filter=ADCRTXUB origin/asf-site >> >> >> >> To see only files that had 100 or more lines changed: >> >> >> >> git diff --stat origin/asf-site | grep -E '[1-9][0-9]{2,}' >> >> >> >> When you are satisfied, publish your changes to origin/asf-site using >> >> these commands: >> >> >> >> git commit --allow-empty -m "Empty commit" # to work around a current >> >> ASF INFRA bug >> >> git push origin asf-site-${GIT_SHA}:asf-site >> >> git checkout asf-site >> >> git branch -D asf-site-${GIT_SHA} >> >> >> >> Changes take a couple of minutes to be propagated. You can verify >> whether >> >> they have been propagated by looking at the Last Published date at the >> >> bottom of http://hbase.apache.org/. It should match the date in the >> >> index.html on the asf-site branch in Git. >> >> >> >> As a courtesy- reply-all to this email to let other committers know you >> >> pushed the site. >> >> >> >> >> >> >> >> If failed, see https://builds.apache.org/job/ >> hbase_generate_website/390/ >> >> console >> > >> > >> > >> > -- >> > -Dima >> > >
