I like the ideal to clean it up and make it clear. I had the same confusion as well. Will look at the JIRA and comment there as well.
Thanks. Jerry On Wed, Aug 2, 2017 at 11:48 PM, Yu Li <car...@gmail.com> wrote: > Dear all, > > Recently in HBASE-18469 <https://issues.apache.org/jira/browse/HBASE-18469> > we found some inconsistency on regionserver request related metrics, > including: > 1. totalRequestCount could be less than readRequestCount+writeRequestCount > 2. For multi request, we count action count into totalRequestCount, while > for scan with caching we count only one. > > To fix the inconsistency, we plan to make below changes: > 1. Make totalRequestCount only counts rpc request, thus multi request will > only count as one for totalRequestCount > 2. Introduce a new metrics in name of "totalRowsRequestCount", which will > count the DML workloads on RS by row-level action, and for this metrics we > will count how many rows included for multi and scan-with-caching request. > > After the change, there won't be any compatibility issue -- existing > monitoring system could still work -- only that totalRequestCount will be > less than previous. And it's recommended to use totalRowsRequestCount to > check the RS DML workload. > > Please kindly let us know if you have any different idea or suggestion > (operators' opinion is especially welcomed). > > Let's make this discussion open for 72 hours and will make the change if no > objections. > > Thanks! > > Best Regards, > Yu
