Hello Team,

Maybe it's time to finally realize the dream of HBASE-10092

Once the logging infrastructure is upgraded, I would be happy to
assist in reviewing and improving the log messages.  I've done a bit
of similar work for the Hive project.  It's tedious but doesn't
require deep knowledge of the overall project and can be done
piecemeal.

Commons Logging states that it requires one to use code guards for
logging debug/trace statements.  However, SLF4J recommends using
parameters for logging which is faster than guards, and I personally
think it's a cleaner approach.  The logging parameters are only
resolved if the log level is appropriate and therefore guards are
often unnecessary. It removes code (the guards) and complexity from
the application code.

This seems like a straight-forward path for the project for eking out
some performance.

https://www.slf4j.org/faq.html#logging_performance
https://commons.apache.org/proper/commons-logging/guide.html#Code_Guards

Thanks.

Reply via email to