+1

Did a quick check.

Downloaded the src.tar.gz.   Unzipped it.   As Stack mentioned, there is no
hbase-thirdparty-2.0.0 top level directory. README needs minor update to
the package names.

mvn install.  Success.  Checked binary jars, which got installed correctly.

Switched into hbase master branch.  Applied HBASE-19552.v2.patch.  (The
patch needs some re-base.)
Built successfully.

mvn clean assembly:single
    No binaries built.   Only produced
the hbase-thirdparty-2.0.0-src.tar.gz.   Unzipping the
src.tar.gz interestingly shows the correct hbase-thirdparty-2.0.0 top level
layout.


On Fri, Dec 22, 2017 at 3:16 PM, Stack <[email protected]> wrote:

> On Fri, Dec 22, 2017 at 11:26 AM, Misty Stanley-Jones <[email protected]>
> wrote:
>
> > +1
> >
> > Tbh I am unclear how to properly exercise this artifact. Can we get some
> > guidance for the future?
> >
> >
> For sure. Its a bit tough exercising this in isolation, this release in
> particular. Needs patch applied to hbase core that picks up new locations
> to try it. But yeah, going forward, for sure. Thanks for the vote Misty.
>
> S
>
>
>
> > On Dec 19, 2017 1:04 PM, "Mike Drob" <[email protected]> wrote:
> >
> > > HBase Devs,
> > >
> > > In preparation for our hbase-2.0.0-beta releases, it would be
> beneficial
> > to
> > > have updated third-party artifacts.
> > >
> > > These artifacts update the version of netty to 4.1.17 (from 4.1.12) and
> > > change the relocation offset to o.a.h.thirdparty to prevent conflicts
> > with
> > > our other shaded artifacts (relocated during the build).
> > >
> > > This artifact was tested locally against current hbase master branch
> > > with HBASE-19552 applied.
> > >
> > > Source artifact, signatures, and checksums are available at
> > > https://dist.apache.org/repos/dist/dev/hbase/hbase-
> thirdparty/2.0.0RC0/
> > >
> > > Signed git commit for the release candidate available at
> > > https://git-wip-us.apache.org/repos/asf?p=hbase-thirdparty.
> > git;a=commit;h=
> > > 2b55dc792196a12d9a365a758a518f26c459391e
> > >
> > > Maven repository available at
> > > https://repository.apache.org/content/repositories/orgapachehbase-1187
> > >
> > > This vote will remain open for at least 72 hours. Please review the
> > > artifacts and cast your votes!
> > >
> > > Here's my +1 (non-binding)
> > >
> > > Thanks,
> > > Mike
> > >
> >
>

Reply via email to