Appy created HBASE-19819:
----------------------------
Summary: Decide the place of Checkstyle in build flow
Key: HBASE-19819
URL: https://issues.apache.org/jira/browse/HBASE-19819
Project: HBase
Issue Type: Improvement
Reporter: Appy
Ref: https://issues.apache.org/jira/browse/HBASE-19780
Main questions:
# Should checkstyle (CS) be part of {{mvn install}}. On master, mvn install
(without clean) takes ~3 min and {{mvn checkstyle:checkstyle}} takes ~2min.
I think the reason it's not part of default build might be - our project isn't
clean, and failing because of existing 10k CS issues is useless. Maybe there's
no trivial way of reporting just the new CS issues, and that's why we depend on
QA (which gives just the diff) for checkstyle?
# How to avoid regressions in modules which have been sanitized by [~Jan
Hentschel]. Here's a suggestion building on his:
** Let's add a recommendation in documentation that run mvn checkstyle:check
before submitting patches since it'll catch CS violations in modules which are
perfectly clean.
** Add checkstyle:check as part of main pre-commit build. If there is any
violation in these clean modules (towards which you have put great effort),
then the pre-commit will fail also for the mvn install step, which is an
important one. Thus, clean CK in these modules become hard pre-commit
requirement indirectly.
Let's put a note on dev@ proposing these changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
