Sean Busbey created HBASE-20467:
-----------------------------------

             Summary: Precommit personality should only run checkstyle once if 
we're going to run it at the root.
                 Key: HBASE-20467
                 URL: https://issues.apache.org/jira/browse/HBASE-20467
             Project: HBase
          Issue Type: Bug
          Components: community, test
            Reporter: Sean Busbey


shows up v egregiously on HBASE-20332, but I've seen in a few places where 
we'll do checkstyle at top level as well on individual modules.

eg.:
{code}

+1      checkstyle      0m 25s  hbase-common: The patch generated 0 new + 88 
unchanged - 1 fixed = 88 total (was 89)
+1      checkstyle      0m 12s  The patch hbase-hadoop2-compat passed checkstyle
+1      checkstyle      0m 30s  The patch hbase-client passed checkstyle
+1      checkstyle      0m 11s  The patch hbase-replication passed checkstyle
+1      checkstyle      1m 15s  The patch hbase-server passed checkstyle
+1      checkstyle      0m 17s  The patch hbase-mapreduce passed checkstyle
+1      checkstyle      0m 8s   The patch hbase-testing-util passed checkstyle
+1      checkstyle      0m 28s  The patch hbase-thrift passed checkstyle
+1      checkstyle      0m 11s  The patch hbase-rsgroup passed checkstyle
+1      checkstyle      0m 10s  The patch hbase-shell passed checkstyle
+1      checkstyle      0m 12s  The patch hbase-endpoint passed checkstyle
+1      checkstyle      0m 14s  The patch hbase-backup passed checkstyle
+1      checkstyle      0m 21s  The patch hbase-it passed checkstyle
+1      checkstyle      0m 14s  The patch hbase-examples passed checkstyle
+1      checkstyle      0m 16s  The patch hbase-rest passed checkstyle
+1      checkstyle      0m 9s   The patch hbase-external-blockcache passed 
checkstyle
+1      checkstyle      0m 10s  The patch hbase-shaded passed checkstyle
+1      checkstyle      0m 8s   The patch hbase-shaded-mapreduce passed 
checkstyle
+1      checkstyle      0m 8s   The patch hbase-shaded-check-invariants passed 
checkstyle
+1      checkstyle      0m 9s   The patch 
hbase-shaded-with-hadoop-check-invariants passed checkstyle
+1      checkstyle      2m 38s  root: The patch generated 0 new + 429 unchanged 
- 1 fixed = 429 total (was 430)
{code}

we should use the same shortcut we do with other modules when root is present



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to