ianbuss commented on a change in pull request #1: HBASE-22201 Fixing a number
of issues with test cases
URL: https://github.com/apache/hbase-native-client/pull/1#discussion_r277677219
##########
File path: src/hbase/test-util/mini-cluster.cc
##########
@@ -34,7 +34,7 @@ JNIEnv *MiniCluster::CreateVM(JavaVM **jvm) {
char *classpath = getenv("CLASSPATH");
std::string clspath;
if (classpath == NULL || strstr(classpath, "-tests.jar") == NULL) {
- std::string clsPathFilePath("../target/cached_classpath.txt");
+ std::string
clsPathFilePath("../../../hbase-build-configuration/target/cached_classpath.txt");
Review comment:
Yes, it isn't pretty. It sort of depends on being run from within the
`hbase-native-client` sub-directory of the hbase project proper as well (which
has had `mvn package` run beforehand). This path at least exists though if that
has been done unlike the previous value :) I reckon there's a better way to
manage it more elegantly though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
