Pom is one thing but see here: https://github.com/apache/hbase-connectors/tree/1.0.0RC1/spark#scala-and-spark-versions We allow that user might build for different versions of spark/scala. Keep that in mind? (We should probably stamp on the README.md what versions we do not support). S
On Fri, Apr 26, 2019 at 1:58 PM Artem Ervits <[email protected]> wrote: > fair enough, I checked > https://github.com/apache/hbase-connectors/blob/1.0.0RC1/spark/pom.xml#L44 > and > Spark is bumped to the latest version so doing rewrite will probably make > sense. it is a solid advice going forward. > > On Fri, Apr 26, 2019 at 4:09 PM Sean Busbey <[email protected]> wrote: > > > I'd figure out what version(s) of Spark might require keeping the > > deprecated items before doing the work of rewriting. > > > > On Fri, Apr 26, 2019 at 12:20 PM Artem Ervits <[email protected]> > > wrote: > > > > > > seems like they're Spark method deprecations, requires code rewrite. > > Happy > > > to address these. > > > > > > On Fri, Apr 26, 2019 at 1:18 PM Sean Busbey <[email protected]> wrote: > > > > > > > Are they things we would fix? Or are the unavoidable? > > > > > > > > On Fri, Apr 26, 2019 at 12:16 PM Artem Ervits <[email protected]> > > wrote: > > > > > > > > > > scala-maven-plugin is hiding deprecation warnings for Scala code. > > There > > > > are > > > > > 46 warnings in the branch I'm working in. Do we want to pollute the > > > > console > > > > > with these warnings? Reason I'm asking is that I had to edit the > pom > > to > > > > > have these warnings surface. > > > > > > >
