I mean do the amend with signoff, then force push to PR branch, then merge it... Sigh.
On Thu, May 30, 2019 at 3:47 PM Andrew Purtell <[email protected]> wrote: > Thanks, got it, do one of these before the push to branch to open the PR > and all will be good. > > > On Thu, May 30, 2019 at 3:46 PM Sean Busbey <[email protected]> wrote: > >> via plain git commands, presuming your local author metadata is correct: >> >> git commit --amend --signoff >> >> Or via apache yetus smart-apply-patch when pulling down the PR, again >> presuming your local author metadata is correct. >> >> any one of: >> >> smart-apply-patch --project=hbase --committer HBASE-22461 >> smart-apply-patch --project=hbase --plugins=github --committer 274 >> smart-apply-patch --project=hbase --committer >> https://github.com/apache/hbase/pull/274 >> >> On Thu, May 30, 2019 at 5:12 PM Andrew Purtell <[email protected]> >> wrote: >> > >> > The last couple of changes I've contributed by the GitHub workflow and >> both >> > times I have forgotten to manually add Signed-off-by attribution in the >> PR >> > before squash merging it. Will try to do better. >> > >> > By any chance, does anyone know of a way to add such things by the >> command >> > line to a PR? Just wondering, because my (muscle) memory is driven by >> > command line syntax. >> > >> > -- >> > Best regards, >> > Andrew >> > >> > Words like orphans lost among the crosstalk, meaning torn from truth's >> > decrepit hands >> > - A23, Crosstalk >> > > > -- > Best regards, > Andrew > > Words like orphans lost among the crosstalk, meaning torn from truth's > decrepit hands > - A23, Crosstalk > -- Best regards, Andrew Words like orphans lost among the crosstalk, meaning torn from truth's decrepit hands - A23, Crosstalk
