Hi OpenInx, I meant RegionObserver, but it doesn’t really matter: your patch implemented it in MasterObserver, but either observer would be fine for us. Unfortunately upgrading to 2.2 doesn’t seem to be feasible at the moment, thought it would be a straightforward resolution.
To be more specific: I’m only looking for the possibilities of backporting the 4 new events: pre/post Grant/Revoke, not the entire Procedure V2 refactor. My question was about whether it’s possible at all in the current architecture of branch-2.1. Looks like it’s not, but I’m quite new to HBase and wanted to get confirmation. Regards, Andor > On 2019. Jul 12., at 17:07, OpenInx <[email protected]> wrote: > > Hi Andor: >> to branch-2.1 to make pre/post Grant and Revoke events available in > RegionObserver. > I think you mean MasterObserver. > > This feature was contributed by our XiaoMi HBase team. we did not port > those patches to branch-2.1 > before because we thought the most priority of the branch at that time was > to make it more stable. So > only patches of bug fix were ported to branch-2.1. All new features are > committed in the unreleased > branches. > > Now, we have the 2.2.0 release now, which has included the feature you > need. I think it may be better for you > to upgrade your clusters to 2.2.0, it has some procedure-v2 improvement ( > such as HBASE-21970). Also > there're some incompatible change when rolling upgrade, so please see the > notice[1] carefully. > > [1]. > http://mail-archives.apache.org/mod_mbox/hbase-user/201906.mbox/%3CCAB8hLa=cwke+fcc6_dubysqjxfxtdgs+6gz_vkwpsep1yzp...@mail.gmail.com%3E > > Thanks. > > On Fri, Jul 12, 2019 at 10:37 PM Andor Molnar <[email protected]> wrote: > >> Hi HBase dev, >> >> I’d like to backport "HBASE-21739 Move grant/revoke from regionserver to >> master" to branch-2.1 to make pre/post Grant and Revoke events available in >> RegionObserver. >> >> Currently these commands are implemented in AccessController as rpc >> services. The problem is that AccessController is effectively a >> co-processor which doesn’t have access (or at least it seems to me) to >> CoprocessorHost, so I cannot fire the events in grant() and revoke() >> methods. >> >> Do you think it’s achievable without too much refactoring in >> AccessController? >> >> Regards, >> Andor >> >> >> >>
