Sean Busbey created HBASE-22924:
-----------------------------------
Summary: GitHUB PR job should use when clause to filter to just
PRs.
Key: HBASE-22924
URL: https://issues.apache.org/jira/browse/HBASE-22924
Project: HBase
Issue Type: Improvement
Components: build, community
Reporter: Sean Busbey
Right now the GitHub PR checking job uses a Jenkins environment variable to
stop branch builds:
{code}
# If CHANGE_URL is set (e.g., Github Branch Source
plugin), process it.
# Otherwise exit, because we don't want HBase to do a
# full build. We wouldn't normally do this check for
smaller
# projects. :)
if [[ -z "${CHANGE_URL}" ]]; then
echo "Full build skipped" >
"${WORKSPACE}/${PATCHDIR}/report.html"
exit 0
fi
{code}
instead we should use a Jenkinsfile {{when}} clause
([ref|https://jenkins.io/doc/book/pipeline/syntax/#when]) and the
{{changeRequest()}} filter to say we want to build PRs. Assuming the eventual
adaptation of the JIRA precommit job properly sets that it's testing a change
this should also help reuse there.
{code}
stage ('precommit-run') {
when { changeRequest() }
steps {
...
}
}
{code}
it would also be nice to fold things into a single stage so that we skip the
yetus checkout when we're not going to run tests.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
