saintstack commented on a change in pull request #5: HBASE-23052 add a
jdk7-compt miscellaneous module for use on branch-1
URL: https://github.com/apache/hbase-thirdparty/pull/5#discussion_r326482763
##########
File path: pom.xml
##########
@@ -117,6 +118,7 @@
<developers/>
<!--TODO-->
<properties>
+ <hbase.thirdparty.gson.version>2.8.5</hbase.thirdparty.gson.version>
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>
yyyy-MM-dd'T'HH:mm
Review comment:
About same as the gson-only module PR but messaging is more muddled here I'd
say. I like option #2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
