[
https://issues.apache.org/jira/browse/HBASE-24065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-24065.
----------------------------------
Resolution: Not A Problem
Not a problem after all. The SpotBugs check is indeed invoked from the General
Checks section. It (1) requires the maven plugin to be enabled, which is the
case, and (2) requires a java file to be modified by the PR.
> Enable SpotBugs in PreCommit
> ----------------------------
>
> Key: HBASE-24065
> URL: https://issues.apache.org/jira/browse/HBASE-24065
> Project: HBase
> Issue Type: Task
> Components: build, test
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Major
>
> Yetus's SpotBugs module depends on {{maven_add_install}}. In
> {{Jenkinsfile_GitHub}}, I'm pretty strict on my module definitions, with
> {noformat}
> GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit'
> JDK_SPECIFIC_PLUGINS =
> 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'
> {noformat}
> The general check requests {{all}} but omits {{compile}} and {{maven}}, which
> I think means the {{spotbugs}} check gets dropped. Before HBASE-23767, we had
> just a single yetus that did {{all}}, so {{spotbugs}} would have been run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
