On Fri, Apr 24, 2020 at 6:37 PM 张铎(Duo Zhang) <[email protected]> wrote:
> On branch-2.2- we do not have these versions, I guess there must be a > reason why we introduced these versions? > Yes, the reason for pinning package versions is that it's a Dockerfile best practice, as described in the official guide. On later branches, hadolint is running against these files and flagged this error. However, it seems I made the version numbers too specific, and a more relaxed formulation should be applicable. Nick Dimiduk <[email protected]> 于2020年4月25日周六 上午12:53写道： > > > Thanks for the quick fix. > > > > I wonder -- was I too specific with these version numbers? Is it possible > > to loosen them? Maybe drop the debian-revision [0] component? > > > > [0]: http://manpages.ubuntu.com/manpages/trusty/man5/deb-version.5.html > > > > On Thu, Apr 23, 2020 at 11:51 PM 张铎(Duo Zhang) <[email protected]> > > wrote: > > > > > OK pre commit is also failing. > > > > > > Filed HBASE-24251... > > > > > > 张铎(Duo Zhang) <[email protected]> 于2020年4月24日周五 下午12:07写道： > > > > > > > Fail to build docker image? > > > > > > > > > > > > > > > > > > https://builds.apache.org/job/HBASE-Find-Flaky-Tests/job/master/1587/console > > > > > > > > > > > > *23:22:27* Step 3/4 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq > > -y > > > update && DEBIAN_FRONTEND=noninteractive apt-get -qq -y install > > > --no-install-recommends curl=7.58.0-2ubuntu3.8 > > > python2.7=2.7.17-1~18.04 python-pip=9.0.1-2.3~ubuntu1.18.04.1 > > > python-setuptools=39.0.1-2 && apt-get clean && rm -rf > > > /var/lib/apt/lists/**23:22:29* ---> Running in cd5ccda2f128*23:22:38* > > > [91mE: Version '2.7.17-1~18.04' for 'python2.7' was not found > > > > > > > > *23:22:38* [0mThe command '/bin/sh -c DEBIAN_FRONTEND=noninteractive > > > > apt-get -qq -y update && DEBIAN_FRONTEND=noninteractive apt-get -qq > -y > > > > install --no-install-recommends curl=7.58.0-2ubuntu3.8 > > > > python2.7=2.7.17-1~18.04 python-pip=9.0.1-2.3~ubuntu1.18.04.1 > > > > python-setuptools=39.0.1-2 && apt-get clean && rm -rf > > > /var/lib/apt/lists/*' > > > > returned a non-zero code: 100 > > > > > > > > Anyone has a chance to take a look? Seems the hard coded python > > version > > > > in dev-support/Dockerfile is gone? > > > > > > > > > >
