TestRESTApiClusterManager CNFE is present in pre-commit test failures on https://github.com/apache/hbase/pull/2222. Also, surprisingly, shadedjars check is failing with NPE.
Apart from above issues, build and tests are overall good locally with 3.4.0. However, I am not sure about the issue with shadedjars and how much of an actual blocker it is and hence, keeping an eye over the PR for update before providing the vote. On 2020/08/11 16:05:46, Josh Elser <els...@apache.org> wrote: > +1 (binding) > > Everything with 3.4.0 looks fine to me. I used the staged artifacts at > the URL which Viraj corrected. A couple of non-blocking issues. > > * NOTICE needs updating (2018 year) > * hbase-thirdparty build fails w/o a `clean` (see below) > * TestRESTApiClusterManager failed in the hbase build, looking for > non-shaded jersey. Not a blocker for this release (also below) > > > ``` > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on > project hbase-shaded-jetty: Error creating shaded jar: duplicate entry: > META-INF/services/org.apache.hbase.thirdparty.org.eclipse.jetty.http.HttpFieldPreEncoder > > -> [Help 1] > ``` > > ``` > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 0.308 s <<< FAILURE! - in org.apache.hadoop.hbase.TestRESTApiClusterManager > [ERROR] > org.apache.hadoop.hbase.TestRESTApiClusterManager.isRunningPositive > Time elapsed: 0.165 s <<< ERROR! > java.lang.RuntimeException: java.lang.ClassNotFoundException: > org.glassfish.jersey.client.JerseyClientBuilder > at > org.apache.hadoop.hbase.TestRESTApiClusterManager.before(TestRESTApiClusterManager.java:63) > Caused by: java.lang.ClassNotFoundException: > org.glassfish.jersey.client.JerseyClientBuilder > at > org.apache.hadoop.hbase.TestRESTApiClusterManager.before(TestRESTApiClusterManager.java:63) > ``` > > I'll try to help out fixing these. > > On 8/8/20 11:02 AM, 张铎(Duo Zhang) wrote: > > Please vote on this Apache hbase thirdparty release candidate, > > hbase-thirdparty-3.4.0RC1 > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache hbase thirdparty 3.4.0 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 3.4.0RC1: > > > > https://github.com/apache/hbase-thirdparty/tree/3.4.0RC1 > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > > > https://dist.apache.org/repos/dist/dev/hbase/3.4.0RC1/ > > > > Maven artifacts are available in a staging repository at: > > > > https://repository.apache.org/content/repositories/orgapachehbase-1403/ > > > > Artifacts were signed with the 9AD2AE49 key which can be found in: > > > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > We shade jetty and jersey in this version for addressing the conflicts > > between jetty 9.3 and 9.4, as hadoop recently upgraded its jetty from 9.3 > > to 9.4 in patch releases. > > > > To learn more about Apache hbase thirdparty, please see > > > > http://hbase.apache.org/ > > > > Thanks, > > Your HBase Release Manager > > >
