Hi guys,
Sorry to bother everyone, but we need some help on this discussion
about a recent change in HBASE-24471 that adds a new state
`INIT_META_WRITE_FS_LAYOUT` to InitMetaProcedure. Within the state, it
introduces a new logic to remove the meta directory if it exists.
private static void writeFsLayout(Path rootDir, Configuration conf)
throws IOException {
LOG.info("BOOTSTRAP: creating hbase:meta region");
FileSystem fs = rootDir.getFileSystem(conf);
Path tableDir = CommonFSUtils.getTableDir(rootDir,
TableName.META_TABLE_NAME);
if (fs.exists(tableDir) && !fs.delete(tableDir, true)) {
LOG.warn("Can not delete partial created meta table, continue...");
}
HBASE-24471 is an incompatible change as mentioned in release note, if
a HM restarts and hit into InitMetaProcedure#INIT_META_WRITE_FS_LAYOUT
, it considers the meta is `partial` and it should be deleted even if
the meta may not be partial (however, we cannot tell from the HFiles
or table data itself if the table is partial or inconsistent).
So, I’m wondering if we can keep the meta without deleting it, or
leave it to repair action if any inconsistency happens after the meta
bootstrap , e.g. using HBCK.
Apologize in advance to Duo, and I want some ideas from a broader
audience how we can move forward from the discussion on the PR#2237
P.S. I need to be honest on our use cases, we’re restarting a cluster
on a fresh ZK data (the cloud use cases that restarting on no ZK and
WAL but only HFiles) that will lead into resubmitting
InitMetaProcedure and triggers the first state of
INIT_META_WRITE_FS_LAYOUT that deletes the meta. As such we’re
suffering from the other side that even if the meta direcotry has the
right data content, we need to rebuild it.
Related JIRAs
* https://issues.apache.org/jira/browse/HBASE-24471
* https://issues.apache.org/jira/browse/HBASE-24833
Related PRs
* PR#1806,
https://github.com/apache/hbase/commit/4d5efec76718032a1e55024fd5133409e4be3cb8#
* PR#2237 still in progress of discussion,
https://github.com/apache/hbase/pull/2237
Thanks,
Stephen
