[ https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stack resolved HBASE-24914. ----------------------------------- Hadoop Flags: Reviewed Resolution: Fixed Merged PR. Thanks for the fix [~Ddupg] > Remove duplicate code appearing continuously in method > ReplicationPeerManager.updatePeerConfig > ---------------------------------------------------------------------------------------------- > > Key: HBASE-24914 > URL: https://issues.apache.org/jira/browse/HBASE-24914 > Project: HBase > Issue Type: Improvement > Components: Replication > Affects Versions: 3.0.0-alpha-1 > Reporter: Sun Xin > Assignee: Sun Xin > Priority: Minor > Fix For: 3.0.0-alpha-1 > > > In > [ReplicationPeerManager.updatePeerConfig|https://github.com/apache/hbase/blob/1164531d5ab519ab58af82ba3849f8fcded3453f/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L272], > I found duplicate code appearing twice continuously, so remove once. > {code:java} > newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); > newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration()); > newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); > newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration()); > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)