Seems reasonable to at least have an easy option for running the permutations even if it's not the default.
On Mon, Dec 7, 2020 at 3:23 PM Andrew Purtell <apurt...@apache.org> wrote: > > The dev-support/hbase-vote.sh has not been updated to match that logic. > > Ok, shall we at least do that? Seems like a good idea, although of course > the voter's resources will be consumed for a longer period of time. > > > On Mon, Dec 7, 2020 at 2:45 PM Nick Dimiduk <ndimi...@apache.org> wrote: > > > On Mon, Dec 7, 2020 at 2:30 PM Andrew Purtell <apurt...@apache.org> > wrote: > > > > > Do we have a list of optional build profiles that are required or > > > recommended for release or release testing? I might have missed it. > > > > > > If we do not have one, shall we start one? > > > > > > If we should start a list of optional build profiles that the RM and > > > release testers should ensure are successful, what should be on it? > > Should > > > Java 11 and Hadoop 3 be on it? > > > > > > I am in favor of starting this practice with this release and this RC. > > > > > > > These permutations are codified on a per-branch basis in our Jenkinsfile. > > The dev-support/hbase-vote.sh has not been updated to match that logic. > > > > Should we break this question out into a DISCUSS thread? > > > > > > > I don't think it's necessary, though I suppose the details are not well > > socialized. > > > > On Mon, Dec 7, 2020 at 1:52 PM Nick Dimiduk <ndimi...@apache.org> wrote: > > > > > > > Has anyone successfully built/run this RC with JDK11 and Hadoop3 > > profile? > > > > > > > Presumably this test does run with JDK11 + Hadoop3, given HBase Nightly / > > branch-2.4 / #3 [0] was green. > > > > [0]: > > > > > https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/branch-2.4/3/pipeline/102 > > > > > I'm seeing test failures locally in the hbase-asyncfs module. > > > > Reproducible with: > > > > > > > > $ > > > > > > > > > > > > > > JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home > > > > mvn clean install -Dhadoop.profile=3.0 > > > > > > > > > > -Dtest=org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput > > > > ... > > > > [INFO] Running > > > > org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput > > > > > > > > > > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time > elapsed: > > > > 1.785 s <<< FAILURE! - in > > > > org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput > > > > > > > > [ERROR] org.apache.hadoop.hbase.io > > > > .asyncfs.TestFanOutOneBlockAsyncDFSOutput > > > > Time elapsed: 1.775 s <<< ERROR! > > > > > > > > java.lang.ExceptionInInitializerError > > > > > > > > > > > > at > > > > org.apache.hadoop.hbase.io > > > > > > > > > > .asyncfs.TestFanOutOneBlockAsyncDFSOutput.setUp(TestFanOutOneBlockAsyncDFSOutput.java:87) > > > > > > > > Caused by: java.lang.IllegalArgumentException: Invalid Java version > > > > 11.0.9.1 > > > > > > > > at > > > > org.apache.hadoop.hbase.io > > > > > > > > > > .asyncfs.TestFanOutOneBlockAsyncDFSOutput.setUp(TestFanOutOneBlockAsyncDFSOutput.java:87) > > > > > > > > On Thu, Dec 3, 2020 at 4:05 PM Andrew Purtell <apurt...@apache.org> > > > wrote: > > > > > > > > > Please vote on this Apache hbase release candidate, hbase-2.4.0RC1 > > > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.4.0 > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > The tag to be voted on is 2.4.0RC1: > > > > > > > > > > https://github.com/apache/hbase/tree/2.4.0RC1 > > > > > > > > > > The release files, including signatures, digests, as well as > > CHANGES.md > > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.4.0RC1/ > > > > > > > > > > Customarily Maven artifacts would be available in a staging > > repository. > > > > > Unfortunately I was forced to terminate the Maven deploy step after > > > > > the upload ran for more than four hours and my build equipment > > > > > needed to be relocated, with loss of network connectivity. This RC > > has > > > > > been delayed long enough. A temporary Maven repository is not a > > > > > requirement for a vote. I will retry Maven deploy tomorrow. I can > > > > > promise the artifacts for this RC will be staged in Apache Nexus > and > > > > > ready for release well ahead of the earliest possible time this > vote > > > > > can complete. > > > > > > > > > > Artifacts were signed with the apurt...@apache.org key which can > be > > > > found > > > > > in: > > > > > > > > > > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > > > > > > > The API compatibility report for this RC can be found at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.4.0RC1/api_compare_2.4.0RC1_to_2.3.0.html > > > > > > > > > > The changes are mostly added methods, which conform to the > > > compatibility > > > > > guidelines for a new minor release. There is one change to the > public > > > > > Region interface that alters the return type of a method. This is > > > > > equivalent to a removal then addition and can be a binary > > compatibility > > > > > problem. However to your RM's eye the change looks intentional and > is > > > > > part of an API improvement project, and a compatibility method is > not > > > > > possible here because Java doesn't consider return type when > deciding > > > if > > > > > one method signature duplicates another. > > > > > > > > > > To learn more about Apache HBase, please see > > > > > > > > > > http://hbase.apache.org/ > > > > > > > > > > Thanks, > > > > > Your HBase Release Manager > > > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Andrew > > > > > > Words like orphans lost among the crosstalk, meaning torn from truth's > > > decrepit hands > > > - A23, Crosstalk > > > > > > > > -- > Best regards, > Andrew > > Words like orphans lost among the crosstalk, meaning torn from truth's > decrepit hands > - A23, Crosstalk >
