I missed one step, I also need to check top couple jiras to see if they are included in the release.
On Mon, Jan 11, 2021 at 10:55 AM Huaxiang Sun <[email protected]> wrote: > Yeah, I just found out that these two jiras were resolved after we ran the > git check. 2.3.4 tag includes these two jiras, this is why the git check > did not complain. > Yeah, better to ask everyone to hold on from committing backports. Thanks > Viraj. > > > > On Sat, Jan 9, 2021 at 10:54 AM Viraj Jasani <[email protected]> wrote: > >> Thanks Huaxiang. I think this discrepancy would occur because of Jira's >> fix >> versions. If both these Jiras had fix versions 2.3.4, release script would >> have included them in CHANGES.md. >> >> Keeping "RC prep" and "backports landing on release branch" both in sync >> is >> a common problem. I think we could synchronize them by asking everyone to >> hold on from committing backports to release branch maybe just before >> starting RC prep (by sending separate notice on dev@ ). >> >> >> On Sat, 9 Jan 2021 at 11:21 PM, Huaxiang Sun <[email protected]> >> wrote: >> >> > Thanks Viraj. Let me check why the script does not catch these two cases >> > and rebuild a new one. >> > >> > Huaxiang >> > >> > On Sat, Jan 9, 2021 at 6:22 AM Viraj Jasani <[email protected]> wrote: >> > >> > > Oops, HBASE-25483 and HBASE-25434 both have fix >> > > version 2.3.5 and hence not included in CHANGES.md, >> > > but corresponding commits are already part of 2.3.4RC0: >> > > https://github.com/apache/hbase/tree/2.3.4RC0 >> > > >> > > Unfortunately, we will have to sink RC0. >> > > >> > > >> > > On 2021/01/09 01:30:44, Huaxiang Sun <[email protected]> wrote: >> > > > Please vote on this Apache hbase release candidate, >> > > > >> > > > hbase-2.3.4RC0 >> > > > >> > > > >> > > > The VOTE will remain open for at least 72 hours. >> > > > >> > > > >> > > > [ ] +1 Release this package as Apache hbase 2.3.4 >> > > > >> > > > [ ] -1 Do not release this package because ... >> > > > >> > > > >> > > > The tag to be voted on is 2.3.4RC0: >> > > > >> > > > >> > > > https://github.com/apache/hbase/tree/2.3.4RC0 >> > > > >> > > > >> > > > The release files, including signatures, digests, as well as >> CHANGES.md >> > > > >> > > > and RELEASENOTES.md included in this RC can be found at: >> > > > >> > > > >> > > > https://dist.apache.org/repos/dist/dev/hbase/2.3.4RC0/ >> > > > >> > > > >> > > > Maven artifacts are available in a staging repository at: >> > > > >> > > > >> > > > >> > > >> https://repository.apache.org/content/repositories/orgapachehbase-1423/ >> > > > >> > > > >> > > > Artifacts were signed with the [email protected] key (Built by >> Michael >> > > > Stack <[email protected]>) which can be found in: >> > > > >> > > > >> > > > https://dist.apache.org/repos/dist/release/hbase/KEYS >> > > > >> > > > >> > > > To learn more about Apache hbase, please see >> > > > >> > > > >> > > > http://hbase.apache.org/ >> > > > >> > > > >> > > > Thanks, >> > > > >> > > > Your HBase Release Manager >> > > > >> > > >> > >> >
