[
https://issues.apache.org/jira/browse/HBASE-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-25872.
-------------------------------
Fix Version/s: 2.5.0
3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to master and branch-2.
Thanks [~Ddupg] for reviewing.
> Add documentation for LoadBalancer about synchronization
> --------------------------------------------------------
>
> Key: HBASE-25872
> URL: https://issues.apache.org/jira/browse/HBASE-25872
> Project: HBase
> Issue Type: Sub-task
> Components: Balancer, documentation
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In general, the balanceCluster call is not thread safe and we only allow one
> balanceCluster call at the same time, so we need to synchronize
> balanceCluster, onConfigurationChange, and setClusterMetrics(which will be
> called periodically, maybe we should rename it to updateClusterMetrics).
> Most setters do not need to be synchronized as they will only be called once
> before initialization.
> And anothe group of methods are XXXAssignment, these methods should be thread
> safe and should not be synchronized to improve the assignment performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)