Yutong Xiao created HBASE-26083:
-----------------------------------
Summary: When CombinedBlockCache L1 miss metric is always 0
Key: HBASE-26083
URL: https://issues.apache.org/jira/browse/HBASE-26083
Project: HBase
Issue Type: Bug
Affects Versions: 2.4.4, 1.7.0
Reporter: Yutong Xiao
Assignee: Yutong Xiao
In CombinedBlockCache getBlock method
{code:java}
public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
boolean repeat, boolean updateCacheMetrics) {
// TODO: is there a hole here, or just awkwardness since in the lruCache
getBlock
// we end up calling l2Cache.getBlock.
// We are not in a position to exactly look at LRU cache or BC as BlockType
may not be getting
// passed always.
return l1Cache.containsBlock(cacheKey)?
l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics):
l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
}
{code}
If L1 does not contains cacheKey, it will never check it in L1, so that L1 miss
metrics is always 0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
