Thanks for the suggestions! I am going to keep the proto and deprecate the proto message. If there are any different opinions, we can still discuss them here or in jira HBASE-26091.
------------------ Original ------------------ From: "????(Duo Zhang)";<[email protected]>; Send time: Tuesday, Jul 20, 2021 9:59 AM To: "HBase Dev List"<[email protected]>; Subject: Re: [DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter BTW, you can try to deprecated proto message https://github.com/protocolbuffers/protobuf/issues/1734 Stack <[email protected]> ??2021??7??19?????? ????11:15?????? > I suggest keeping the proto. > S > > On Sat, Jul 17, 2021 at 1:15 PM ?????? <[email protected]> wrote: > > > Hi, > > > > As https://issues.apache.org/jira/browse/HBASE-13347 describes, the > > FirstKeyValueMatchingQualifiersFilter was deprecated in 2.0 and will be > > removed in 3.0. Now we need to remove it in 3.0 but there are proto > > declareation of FirstKeyValueMatchingQualifiersFilter in Filter.proto. > > > > If the proto declaration of FirstKeyValueMatchingQualifiersFilter is > > removed, serialization problems and unknown errors may occur when the old > > version of hbase-client accesses the new version of the server, which may > > puzzle users. > > > > Should we remove the proto declaration directly? Or throw > RuntimeException > > when the user uses FirstKeyValueMatchingQualifiersFilter? Hope to get > your > > suggestions. > > > > Thanks, > > Zhuoyue Huang > > > > ????????iPhone >
