What about just switching to use google java style? Nick Dimiduk <[email protected]> 于2022年1月13日周四 03:22写道：
> Hey all. > > Discussion on the PR has resulted in an impasse of opinion, but also > renewed interest in improvements to static analysis in general > (HBASE-26617). > > I think that this kind of code hygiene is very important for the long-term > maintenance of a large project like ours and especially one that accepts > contributions from a broad audience. I would really appreciate it if some > more folks would chime into these discussions on PRs, or bring your > concerns back up to this thread. I'm game to help see the work done, but we > need more voices to participate in defining what is required by the > community. > > Thanks in advance, > Nick > > On Thu, Dec 9, 2021 at 3:58 PM Nick Dimiduk <[email protected]> wrote: > > > Heya, > > > > I have posted a small change to our checkstyle configuration on > > HBASE-26536. This change will relax the whitespace rules regarding the > > left-curly-bracket ('{') character. Specifically, I intend this change to > > allow short expressions that include a nested scope that fits entirely on > > one line. The example I provide is: > > > > if (foo == null) { return null; } > > > > This whitespace style is already present (though I think not in popular > > usage) within the codebase. Please take a look and let me know if you > have > > any concerns about making this change. > > > > Thanks, > > Nick > > > > https://issues.apache.org/jira/browse/HBASE-26536 > > https://github.com/apache/hbase/pull/3913 > > >
