Hi team, Let's get some more eyes on the open ErrorProne issues, try to land the ones that have patches available. Looks like the MOB fixes are close too.
I'll dust off my signing keys and find some hardware. Maybe we can have another RC on Monday or Tuesday. Thanks, Nick On Thu, Aug 11, 2022 at 4:35 PM Peter Somogyi <[email protected]> wrote: > I'd like to include HBASE-27281 if I'm not too late. This is to keep API > compatibility. > > On Thu, Aug 11, 2022 at 5:26 AM 张铎(Duo Zhang) <[email protected]> > wrote: > > > OK, no problem :) > > > > Andrew Purtell <[email protected]> 于2022年8月11日周四 10:48写道： > > > > > > Also I only got about halfway through the modules. hbase-server may > have > > many findings. Will get to it when back. > > > > > > > On Aug 10, 2022, at 7:46 PM, Andrew Purtell < > [email protected]> > > wrote: > > > > > > > > Those error prone cleanups don’t change functionality so I think > they > > can go in any time. 2.5.1? Etc > > > > > > > >> On Aug 10, 2022, at 7:16 PM, 张铎 <[email protected]> wrote: > > > >> > > > >> This is still some error prone cleanup PR pending. > > > >> > > > >> I think the hbase-http and hbase-it are good to go, I could help > > > >> merging them. The hbase-common and hbase-examples still need more > > > >> reviews. > > > >> > > > >> But maybe this could done after the 2.5.0 is out? Since they are not > > > >> likely to touch the public API or introduce big refactoring. > > > >> > > > >> > > > >> Andrew Purtell <[email protected]> 于2022年8月11日周四 05:32写道： > > > >> > > > >>> > > > >>> Please, do. > > > >>> > > > >>>> On Wed, Aug 10, 2022 at 2:20 PM Nick Dimiduk <[email protected] > > > > wrote: > > > >>>> > > > >>>> I can give it a go, if you’d like. No problem from my perspective. > > I’m also > > > >>>> happy to help along someone new who’d have a go at it, if there’s > > another > > > >>>> volunteer. Thanks for pushing, Andrew. > > > >>>> > > > >>>> -n > > > >>>> > > > >>>> On Wed, Aug 10, 2022 at 19:28 Andrew Purtell < > > [email protected]> > > > >>>> wrote: > > > >>>> > > > >>>>> By fixVersion is what I use. > > > >>>>> > > > >>>>> We got heads down on something time critical at my employer. I > > also am > > > >>>>> going on vacation next week for two weeks. Does someone want to > > volunteer > > > >>>>> to spin the next RC? Otherwise I can pick this back up at the end > > of the > > > >>>>> month. There would be no reason for such a delay at this point > > other than > > > >>>>> RM availability. > > > >>>>> > > > >>>>> > > > >>>>>> On Aug 10, 2022, at 9:12 AM, Bryan Beaudreault < > > > >>>> [email protected]> > > > >>>>> wrote: > > > >>>>>> > > > >>>>>> Are there any remaining blockers for 2.5.0? Also if there's an > > easy > > > >>>> way > > > >>>>> to > > > >>>>>> view this in JIRA (beyond a custom search for fixVersion=2.5.0) > > please > > > >>>>> let > > > >>>>>> me know. > > > >>>>>> > > > >>>>>>> On Thu, Jul 14, 2022 at 9:40 PM Bryan Beaudreault < > > > >>>>> [email protected]> > > > >>>>>>> wrote: > > > >>>>>>> > > > >>>>>>> Sounds good. Thanks all for the consideration. > > > >>>>>>> > > > >>>>>>> On Thu, Jul 14, 2022 at 7:39 PM Andrew Purtell < > > [email protected]> > > > >>>>>>> wrote: > > > >>>>>>> > > > >>>>>>>> HBASE-27204 was filed because we are pushing on RPC. This is > > good > > > >>>>>>>> progress. > > > >>>>>>>> Let's keep going. I will move out RC1 by one week, to next > > Friday. > > > >>>>>>>> I've also embarked on another (quixotic?) sweep of error prone > > > >>>>> findings on > > > >>>>>>>> HBASE-27198, and sometimes those are easier to get into a > minor, > > > >>>>>>>> depending, > > > >>>>>>>> but this stuff is minor and won't hold it up if that's all > that > > > >>>>> remains. > > > >>>>>>>> > > > >>>>>>>> On Mon, Jul 11, 2022 at 6:18 PM Andrew Purtell < > > [email protected]> > > > >>>>>>>> wrote: > > > >>>>>>>> > > > >>>>>>>>> We have landed several fixes for referencing counting > > concerns, with > > > >>>>> one > > > >>>>>>>>> pending, and the SimpleRpcServer problem has also been > > addressed. > > > >>>>>>>>> Therefore, I would like to roll 2.5.0RC1 by the end of this > > week. > > > >>>> Time > > > >>>>>>>> to > > > >>>>>>>>> get the train moving again. > > > >>>>>>>>> > > > >>>>>>>>> There is one blocker filed by Duo on HBASE-27189 which has an > > > >>>>> associated > > > >>>>>>>>> PR we can apply. I put the issue into Patch Available state > > and am > > > >>>>>>>> prepared > > > >>>>>>>>> to merge the PR. After this one there are six other issues in > > Patch > > > >>>>>>>>> Available state: HBASE-27097 (simplerpcserver fix), > HBASE-27188 > > > >>>>> (metrics > > > >>>>>>>>> improvement), HBASE-27186 (metrics improvement), HBASE-27161 > > (test > > > >>>>>>>>> improvement), HBASE-27153 (tracing improvement), HBASE-27088 > > > >>>>>>>> (integration > > > >>>>>>>>> test improvement). I hope we can get these all landed in the > > next > > > >>>>>>>> couple of > > > >>>>>>>>> days. > > > >>>>>>>>> > > > >>>>>>>>> Best, > > > >>>>>>>>> Andrew > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>> > > > >>>>>>>> -- > > > >>>>>>>> Best regards, > > > >>>>>>>> Andrew > > > >>>>>>>> > > > >>>>>>>> Unrest, ignorance distilled, nihilistic imbeciles - > > > >>>>>>>> It's what we’ve earned > > > >>>>>>>> Welcome, apocalypse, what’s taken you so long? > > > >>>>>>>> Bring us the fitting end that we’ve been counting on > > > >>>>>>>> - A23, Welcome, Apocalypse > > > >>>>>>>> > > > >>>>>>> > > > >>>>> > > > >>>> > > > >>> > > > >>> > > > >>> -- > > > >>> Best regards, > > > >>> Andrew > > > >>> > > > >>> Unrest, ignorance distilled, nihilistic imbeciles - > > > >>> It's what we’ve earned > > > >>> Welcome, apocalypse, what’s taken you so long? > > > >>> Bring us the fitting end that we’ve been counting on > > > >>> - A23, Welcome, Apocalypse > > >
