[ 
https://issues.apache.org/jira/browse/HBASE-28090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-28090.
-------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

Pushed to master and branch-3.

I tried to cherry-pick to branch-2, and then noticed that, we rely on the 
ReplicationSourceShipper to get the start offset for creating the 
ReplicationSourceWALReader, so it is not easy to apply the change here without 
a big refactoring.

I think that's why on branch-2.x we need a setWALReader method on 
ReplicationSourceShipper.

Thanks [~wchevreuil] for reviewing!

> Make entryReader field final in ReplicationSourceShipper class
> --------------------------------------------------------------
>
>                 Key: HBASE-28090
>                 URL: https://issues.apache.org/jira/browse/HBASE-28090
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0-beta-1
>
>
> In HBASE-28076 we noticed that while shutting down. the entryReader field 
> could be null and cause NPE.
> The code is a bit different on master and branch-3, and after reviewing, I 
> think



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to