Is it necessary to break support for v1? It would be fine to merge this to master and branch-3. But I think this change falls into the "Dependency Compatibility" portion of our compatibility guidelines[1]. If so, then we should not backport to branch-2 or 2.x.
Generally, I have previously wondered what value the Event and Output enums provide. It requires us to keep the enums updated with async-profiler options, when we could just directly send the user's input to async-profiler. If they specify a bad option, maybe we can show them the error message from async-profiler. This approach might allow for any async-profiler version. [1] https://hbase.apache.org/book.html#hbase.versioning.post10 On Thu, Jan 18, 2024 at 3:45 AM Lars Francke <lars.fran...@gmail.com> wrote: > Hi, > > I just wanted to give a heads-up on an issue I created (thanks for > everyone's help)[1] > > This would be a breaking change as it removes support for > async-profiler v1 but in exchange it does add support for various v2 > features and in general "unbreaks" things that were broken. > > I already have an approved PR[2] but wanted to give the chance to > comment before I merge that sometimes in the next few days or weeks > > Cheers, > Lars > > > [1] <https://issues.apache.org/jira/browse/HBASE-28242> > [2] <https://github.com/apache/hbase/pull/5566> >
