This sounds great to me. The current PR does this, so I think we are all in agreement.
On Tue, Mar 5, 2024 at 10:49 AM 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > I prefer we still have the hbase-examples in the main repo and publish > it to maven central, but we do not need to ship it in the binary > releases. The most important thing for hbase-examples is its source > code, so including it in binary releases does not help. > > Istvan Toth <st...@cloudera.com.invalid> 于2024年3月5日周二 03:28写道： > > > > I don't have a problem with having an examples module in the main repo, > it > > can be useful, and this way it is guaranteed to always work with the > latest > > version, and we don't have to maintain another repo. > > > > Publishing the binary artifact to maven (as we do now) doesn't sound very > > useful, but if nothing depends on it then it doesn't hurt either. It's > > easier to keep publishing it than it is to disable publishing. > > > > I don't really see the need for a separate download (as long as the > > examples can be found easily via the docs). > > > > Thanks, > > Istvan > > > > > > On Mon, Mar 4, 2024 at 7:24 PM Nick Dimiduk <ndimi...@apache.org> wrote: > > > > > Should we remove hbase-examples from the main repository entirely? > Should > > > it be its own download? Should we even ship it in binary form at all? > > > > > > Anyway I’m fine with removing it from the assembly. > > > > > > Thanks, > > > Nick > > > > > > On Mon, 4 Mar 2024 at 13:27, Istvan Toth <st...@apache.org> wrote: > > > > > > > hbase assembly (and consequently the binary distributions) now > depend on > > > > hbase-examples. > > > > > > > > I think this is problematic, as > > > > * many of those examples are explicitly not production quality. > > > > * It adds extra curator dependencies to the assembly and to the > various > > > > HBase classpaths. (whic the rest of HBase does not use) > > > > > > > > I propose removing hbase-examples and its dependencies from the HBase > > > > assembly, starting with HBase 3.0. > > > > > > > > This would have two effects: > > > > - The example code will not be present on the classpath > > > > - Curator libraries will not be added to the HBase classpath. > Depending > > > on > > > > the shaded/non shaded classpath, the Curator from Hadoop in > relocated or > > > > unrelocated form will still be present. > > > > > > > > Related tickets: > > > > HBASE-28416 <https://issues.apache.org/jira/browse/HBASE-28416> : > This > > > > proposal > > > > HBASE-28415 <http://issues.apache.org/jira/browse/HBASE-28415> : > > > Removing > > > > erroneous curator dependency from hbase-endpoint (no brainer) > > > > HBASE-28411 <https://issues.apache.org/jira/browse/HBASE-28411> : > The > > > > original proposal to remove curator completely > > > > > > > > best regards > > > > Istvan > > > > > > > > > > > > > -- > > *István Tóth* | Sr. Staff Software Engineer > > *Email*: st...@cloudera.com > > cloudera.com <https://www.cloudera.com> > > [image: Cloudera] <https://www.cloudera.com/> > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > Cloudera > > on LinkedIn] <https://www.linkedin.com/company/cloudera> > > ------------------------------ > > ------------------------------ > -- *István Tóth* | Sr. Staff Software Engineer *Email*: st...@cloudera.com cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> ------------------------------ ------------------------------
