Oh, sorry! I missed that it was just merged. Thanks again On Tue, Apr 2, 2024 at 7:06 AM Wellington Chevreuil < wellington.chevre...@gmail.com> wrote:
> I've just got the approval from Duo and merged it. Am cherry-picking to > lower branches now. > > Em ter., 2 de abr. de 2024 às 12:02, Bryan Beaudreault < > bbeaudrea...@apache.org> escreveu: > > > Thanks Wellington. Was there a reason to only merge that to master? > > > > On Tue, Apr 2, 2024 at 5:23 AM Wellington Chevreuil < > > wellington.chevre...@gmail.com> wrote: > > > > > Regarding TestBucketCachePersister flakeyness, I have noticed that last > > > week and had submitted a fix in > > > https://issues.apache.org/jira/browse/HBASE-28458. > > > > > > Em sex., 29 de mar. de 2024 às 15:41, Bryan Beaudreault < > > > bbeaudrea...@apache.org> escreveu: > > > > > > > Thanks. I pushed the addendum fix to HBASE-27657. I will start > another > > RC > > > > on Monday so that people have time to notice any other issues to > > include. > > > > > > > > On Fri, Mar 29, 2024 at 11:24 AM 张铎(Duo Zhang) < > palomino...@gmail.com> > > > > wrote: > > > > > > > > > The other parts of the RC are good. > > > > > > > > > > I ran all the UTs and also started a mini cluster to test basic > shell > > > > > commands, all good. > > > > > > > > > > Will vote a +1 after fixing the above compatibility issue. > > > > > > > > > > Thanks. > > > > > > > > > > Bryan Beaudreault <bbeaudrea...@gmail.com> 于2024年3月29日周五 23:10写道： > > > > > > > > > > > > Thanks for catching that. I looked at the compatibility report > but > > > > missed > > > > > > that one. I will work on fixing. > > > > > > > > > > > > If anyone else wants to take a look for other reasons to sink the > > > RC, I > > > > > > will also tackle those before the next one. > > > > > > > > > > > > On Fri, Mar 29, 2024 at 11:07 AM 张铎(Duo Zhang) < > > > palomino...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Sorry but -1 binding > > > > > > > > > > > > > > After checking the compatibility report, I found that we made a > > > > > > > mistake when implementing HBASE-27657. > > > > > > > > > > > > > > The 'createConnection(Configuration conf, ExecutorService pool, > > > final > > > > > > > User user)' method was lost... We should keep it and make it > call > > > the > > > > > > > newly introduced 'createConnection(Configuration conf, > > > > ExecutorService > > > > > > > pool, final User user, Map<String, byte[]> > connectionAttributes)' > > > > > > > method. > > > > > > > This is an unnecessary incompatible change, we should apply an > > > > > > > addendum to add this method back. > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2024年3月29日周五 22:55写道： > > > > > > > > > > > > > > > > OK, I tried several more times, it passed... > > > > > > > > > > > > > > > > Bryan Beaudreault <bbeaudrea...@apache.org> 于2024年3月29日周五 > > > 19:21写道： > > > > > > > > > > > > > > > > > > > > > > > > > > TestBucketCachePersister is passing for me locally. I've > > tried > > > it > > > > > a few > > > > > > > > > times and no issues > > > > > > > > > > > > > > > > > > On Thu, Mar 28, 2024 at 9:19 PM 张铎(Duo Zhang) < > > > > > palomino...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > TestBucketCachePersister always fail for me locally. > > > > > > > > > > > > > > > > > > > > Is this a known issue which is not very critical? > > > > > > > > > > > > > > > > > > > > Bryan Beaudreault <bbeaudrea...@apache.org> > 于2024年3月28日周四 > > > > > 04:01写道： > > > > > > > > > > > > > > > > > > > > > > Please vote on this Apache hbase release candidate, > > > > > > > > > > > hbase-2.6.0RC2 > > > > > > > > > > > > > > > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > > > > > > > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0 > > > > > > > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > > > > > > > > > > > > > The tag to be voted on is 2.6.0RC2: > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/hbase/tree/2.6.0RC2 > > > > > > > > > > > > > > > > > > > > > > This tag currently points to git reference > > > > > > > > > > > > > > > > > > > > > > 413bb6d733f2917ff94ce799306d8ab7c3132373 > > > > > > > > > > > > > > > > > > > > > > The release files, including signatures, digests, as > well > > > as > > > > > > > CHANGES.md > > > > > > > > > > > and RELEASENOTES.md included in this RC can be found > at: > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC2/ > > > > > > > > > > > > > > > > > > > > > > Maven artifacts are available in a staging repository > at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1537/ > > > > > > > > > > > > > > > > > > > > > > Maven artifacts for hadoop3 are available in a staging > > > > > repository > > > > > > > at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1538/ > > > > > > > > > > > > > > > > > > > > > > Artifacts were signed with the 0x74EFF462 key which can > > be > > > > > found > > > > > > > in: > > > > > > > > > > > > > > > > > > > > > > https://downloads.apache.org/hbase/KEYS > > > > > > > > > > > > > > > > > > > > > > To learn more about Apache hbase, please see > > > > > > > > > > > > > > > > > > > > > > http://hbase.apache.org/ > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > Your HBase Release Manager > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
