The new backups system is one of the "flagship" features for the 2.6 release line so it's a shame that these issues with incremental manifest tracking remain. If I'm not mistaken, though, a full backup still works as expected, so these bugs do not prevent taking a backup entirely. I agree that they together are not enough to block the release.
Thank you Dieter for raising the profile of the issues. I see that these tickets don't have very many watchers, so it seems they've gone without notice. On Tue, May 7, 2024 at 2:26 PM Andrew Purtell <apurt...@apache.org> wrote: > This sounds very reasonable to me, especially with the promise of a quick > follow on release of 2.6.1. > > — > > I apologize for not voting on the 2.6 candidates. I will set up a VM > somewhere where I can drive release candidate tests by phone for the next > time but did not think of this in advance. > > > On Tue, May 7, 2024 at 6:54 AM Bryan Beaudreault <bbeaudrea...@apache.org> > wrote: > > > Thanks Dieter. I’m aware of these issues, but I don’t think they are > > blockers. The idea with releasing backups was that it would be > experimental > > in 2.6, as a way to get the feature into more of the community’s hands > and > > increase development. So far that’s working, as evidenced by your team’s > > great work! > > > > 2.6.0 has been pending since late last year, but kept getting delayed for > > various reasons. I’m aware of community members who are waiting on this > for > > their next upgrade and frustrated by the delays. > > > > It’s unfortunate to release a feature with known bugs, but given it’s > > experimental and just one small part of the release I don’t think we > should > > delay further. It will take some time to review and merge the jiras you > > mention, as well as 1-2 others I’m aware of. I will be happy to release > > 2.6.1 as a quick follow up once these land. > > > > What does the PMC think? > > > > On Tue, May 7, 2024 at 5:13 AM Dieter De Paepe > <diete...@ngdata.com.invalid > > > > > wrote: > > > > > -1 non binding > > > > > > I've done some testing of the backup-restore feature the past days, and > > > there's still some issues that I think really should be solved for a > > first > > > release version. > > > PRs are available for all of these: > > > > > > > > > * HBASE-28539: backup merging does not work when using cloud > storage > > > as filesystem > > > * HBASE-28502: backed up tables are not listed correctly in backup > > > metadata, which causes unreliable backup validation > > > * HBASE-28568: the set of tables included in incremental backups > > might > > > be too big > > > * HBASE-28562: another possible failure cause for incremental > backups > > > + possibly cause of overly big backup metadata > > > > > > I also feel HBASE-28084 is an important one, but there's no PR for that > > so > > > far, so I'm fine with skipping that one for 2.6.0. > > > > > > Regards, > > > Dieter > > > > > > On 2024/04/29 19:20:27 Bryan Beaudreault wrote: > > > > Please vote on this Apache hbase release candidate, > > > > hbase-2.6.0RC4 > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0 > > > > [ ] -1 Do not release this package because ... > > > > > > > > The tag to be voted on is 2.6.0RC4: > > > > > > > > https://github.com/apache/hbase/tree/2.6.0RC4 > > > > > > > > This tag currently points to git reference > > > > > > > > de99f8754135ea69adc39da48d2bc2b2710a5366 > > > > > > > > The release files, including signatures, digests, as well as > CHANGES.md > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC4/ > > > > > > > > Maven artifacts are available in a staging repository at: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1542/ > > > > > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1543/ > > > > > > > > Artifacts were signed with the 0x74EFF462 key which can be found in: > > > > > > > > https://downloads.apache.org/hbase/KEYS > > > > > > > > To learn more about Apache hbase, please see > > > > > > > > http://hbase.apache.org/ > > > > > > > > Thanks, > > > > Your HBase Release Manager > > > > > > > > > > > > >
