This method came in via HBASE-28346: Expose checkQuota to Coprocessor Endpoints (#6066).
Our book says: > LimitedPrivate annotation comes with a set of target consumers for the interfaces. Those consumers are coprocessors, phoenix, replication endpoint implementations or similar. At this point, HBase only guarantees source and binary compatibility for these interfaces between patch versions. I agree that this is an ABI-breaking change that is protected by our compatibility statement. I'm dismayed that this isn't flagged by our compatibility report... On Thu, Oct 3, 2024 at 10:57 AM Istvan Toth <st...@cloudera.com.invalid> wrote: > I see a similar issue when trying to build Phoenix with it : > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile > > (default-compile) on project phoenix-core-server: Compilation failure: > > Compilation failure: > > [ERROR] > > > /home/stoty/workspaces/apache-phoenix/phoenix/phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionCoprocessorEnvironment.java:[41,8] > > org.apache.phoenix.coprocessor.DelegateRegionCoprocessorEnvironment is > not > > abstract and does not override abstract method > > checkBatchQuota(org.apache.hadoop.hbase.regionserver.Region,int,int) in > > org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment > > [ERROR] > > > /home/stoty/workspaces/apache-phoenix/phoenix/phoenix-core-server/src/main/java/org/apache/phoenix/iterate/SnapshotScanner.java:[201,47] > > <anonymous org.apache.phoenix.iterate.SnapshotScanner$1> is not abstract > > and does not override abstract method > > checkBatchQuota(org.apache.hadoop.hbase.regionserver.Region,int,int) in > > org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment > > > > RegionCoprocessorEnvironment is @InterfaceAudience.LimitedPrivate , so this > should probably also be treated in a similar way. > > We certainly can fix this in Phoenix, but only in a new release. > > Istvam > > > On Thu, Oct 3, 2024 at 10:21 AM Nick Dimiduk <ndimi...@apache.org> wrote: > > > -1 > > > > In reviewing the compatibility report, I think that we have a breaking > > change to the AsyncTable interface [0]. We have introduced a new method > > without a default implementation. I believe that this is contrary to our > > Client Binary Compatibility [1] statement: > > > > > Client code written to APIs available in a given patch release can run > > unchanged (no recompilation needed) against the new jars of later patch > > versions. > > > > I believe that this change was introduced via HBASE-28770: Support > partial > > results in AggregateImplementation and AsyncAggregationClient (#6167) > [2]. > > > > Let's see if we can add a default implementation that preserves binary > > compatibility. > > > > Thanks, > > Nick > > > > [0]: > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.1RC0/api_compare_2.6.0_to_2.6.1RC0.html#Type_Binary_Problems_Medium > > [1]: https://hbase.apache.org/book.html#hbase.versioning > > [2]: https://issues.apache.org/jira/browse/HBASE-28770 > > > > On Tue, Oct 1, 2024 at 10:51 AM Nick Dimiduk <ndimi...@apache.org> > wrote: > > > > > Please vote on this Apache hbase release candidate, > > > hbase-2.6.1RC0 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache hbase 2.6.1 > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 2.6.1RC0: > > > > > > https://github.com/apache/hbase/tree/2.6.1RC0 > > > > > > This tag currently points to git reference > > > > > > ea9ffa81213bfe2d8d764838c7b962c2151624f1 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.1RC0/ > > > > > > Maven artifacts are available in a staging repository at: > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1558/ > > > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1559/ > > > > > > Artifacts were signed with the 0xEF4EBF27 key which can be found in: > > > > > > https://downloads.apache.org/hbase/KEYS > > > > > > To learn more about Apache hbase, please see > > > > > > http://hbase.apache.org/ > > > > > > Thanks, > > > Your HBase Release Manager > > > > > > > > -- > *István Tóth* | Sr. Staff Software Engineer > *Email*: st...@cloudera.com > cloudera.com <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > ------------------------------ > ------------------------------ >
