I have found a problem when testing with Phoenix, and which possibly
affects other downstream projects using hbase-testing-util.
I have opened  HBASE-29117 to track this.

Hadoop 3.4.x has updated to Kerby 2.0.3, but hbase-testing-util also
directly depends on some Kerby artifacts, which are dependency managed to
1.0.3,
which prevents MiniKDC from starting, and causes a Phoenix test to fail.

I would suggest that we fix this for 2.5.11.

Building HBase with -Dkerby.version=2.0.3 fixes this, but as this is
Hadoop3 minor version dependent, changing the default version to 2.0.3
would probably
break hbase-testing-util similarly when HBase is built with Hadoop 3.3.x or
3.2.x.

We can define separate versions for the Hadoop 2/3 profiles, but since we
only have a single Hadoop 3.0 profile, we cannot easily set the version
based on the Hadoop 3 minor version. We COULD define profiles based on
hadoop.version, but we'd have add a separate profile for each Hadoop
version,
as AFAIR Maven cannot handle multiple properties nor regexes in the
activation tag.

Since we do not publish artifacts built with Hadoop 3.2/3.3 I think that it
is OK to require manually overriding the Kerby version when building with
older Hadoop 3 versions (as long as we document it)

What do you think ?

Istvan

On Fri, Feb 7, 2025 at 3:46 AM 张铎(Duo Zhang) <palomino...@gmail.com> wrote:

> +1 binding
>
> Checked sigs and sums: Matched
> Rat check: Passed
> LICENSE and NOTICE: In place
> Compatibility report: 100% compatible
> Built from source(Temurin-17.0.12+7):
>   mvn clean install -DskipTests -Dhadoop.profile=3.0
>   Passed
> Run UTs:
>   mvn -Dsurefire.firstPartForkCount=1C
> -Dsurefire.secondPartForkCount=1C -Dsurefire.rerunFailingTestsCount=3
> -Dhadoop.profile=3.0 test -PrunAllTests -fn
>   TestBasicWALEntryStreamFSHLog always failed for me and it is also on
> the flaky dashboard with a very high failure rate but not 100%, so
> should not be a blocker.
> Start a mini cluster:
>   Succeeded.
>   Check logs and web pages, nothing unusual
>   Run these shell commands, looks fine
>     list
>     create 't','f'
>     put 't','r','f:q','value'
>     get 't','r'
>     list
>     disable 't'
>     drop 't'
>     list
> Run LTT to load 10000 rows:
>   ./bin/hbase ltt -write 4:1024 -num_keys 10000
>   Passed
>   Run these shell commands, looks fine
>     count 'cluster_test'
>     scan 'cluster_test', {LIMIT=>10}
>     scan 'cluster_test', {FILTER =>
> org.apache.hadoop.hbase.filter.KeyOnlyFilter.new(true)}
>     flush 'cluster_test'
>     major_compact 'cluster_test'
>     disable 'cluster_test'
>     drop 'cluster_test'
>
> Nick Dimiduk <ndimi...@apache.org> 于2025年2月5日周三 23:40写道:
> >
> > +1
> >
> >         * Signature: ok
> >         * Checksum : ok
> >         * Rat check (1.8.0_362): ok
> >          - mvn clean apache-rat:check -D skipTests=true
> >         * Built from source (1.8.0_362): ok
> >          - mvn clean install -D skipTests=true -DskipTests
> >         * Built from source (17.0.13): ok
> >          - mvn clean install -D skipTests=true -D hadoop.profile=3.0
> -DskipTests
> >
> > On Tue, Feb 4, 2025 at 3:20 PM 张铎(Duo Zhang) <palomino...@gmail.com>
> wrote:
> > >
> > > There is a data loss issue HBASE-29111.
> > >
> > > Of course it is there for a long time so not a blocker for this
> > > release, just reminding.
> > > You guys can consider whether to sink this RC and include it.
> > >
> > > Thanks.
> > >
> > > Viraj Jasani <vjas...@apache.org> 于2025年2月2日周日 03:45写道:
> > > >
> > > > Please vote on this Apache hbase release candidate, hbase-2.5.11RC0
> > > >
> > > > The VOTE will remain open for at least 72 hours.
> > > >
> > > > [ ] +1 Release this package as Apache hbase 2.5.11
> > > > [ ] -1 Do not release this package because ...
> > > >
> > > > The tag to be voted on is 2.5.11RC0:
> > > >
> > > > https://github.com/apache/hbase/tree/2.5.11RC0
> > > >
> > > > This tag currently points to git reference
> > > >
> > > > 84a595672ec7aa219a2eb729aeb4e371e68e6a48
> > > >
> > > > The release files, including signatures, digests, as well as
> CHANGES.md
> > > > and RELEASENOTES.md included in this RC can be found at:
> > > >
> > > > https://dist.apache.org/repos/dist/dev/hbase/2.5.11RC0/
> > > >
> > > > Maven artifacts are available in a staging repository at:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapachehbase-1563/
> > > >
> > > > Maven artifacts for hadoop3 are available in a staging repository at:
> > > >
> > > >
> https://repository.apache.org/content/repositories/orgapachehbase-1564/
> > > >
> > > > Artifacts were signed with the 0xD5365CCD key which can be found in:
> > > >
> > > > https://downloads.apache.org/hbase/KEYS
> > > >
> > > > To learn more about Apache hbase, please see
> > > >
> > > > http://hbase.apache.org/
> > > >
> > > > Thanks,
> > > > Your HBase Release Manager
>


-- 
*István Tóth* | Sr. Staff Software Engineer
*Email*: st...@cloudera.com
cloudera.com <https://www.cloudera.com>
[image: Cloudera] <https://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
------------------------------

Reply via email to